Add additionalFormats to fallback and make formats public#415
Merged
Add additionalFormats to fallback and make formats public#415
Conversation
Co-Authored-By: cotw-fabier <112340360+cotw-fabier@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 62 62
Lines 10363 10364 +1
=======================================
+ Hits 9114 9115 +1
Misses 1249 1249 ☔ View full report in Codecov by Sentry. |
amantoux
approved these changes
Aug 25, 2024
Member
amantoux
left a comment
amantoux
left a comment
There was a problem hiding this comment.
LGTM
I guess the natice autoformats are made public to allow users to cherrypick
It would be nice to add a comment in the PR (to avoid guessing the reason :))
Member
Author
I found it unnecessary, but if you think it's needed I can add the test too. @amantoux |
Member
If not too long to write, I think it is worth |
amantoux
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #372.
Made current auto formats public for users to be able to cherrypick.